Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md: Fix resources in alphabetical order #945

Merged
merged 1 commit into from
Dec 9, 2017
Merged

README.md: Fix resources in alphabetical order #945

merged 1 commit into from
Dec 9, 2017

Conversation

johlju
Copy link
Member

@johlju johlju commented Dec 9, 2017 •
edited by joeyaiello
Loading

Pull Request (PR) description

This Pull Request (PR) fixes the following issues:
Fixes #908

Task list:

  • Change details added to Unreleased section of CHANGELOG.md?
  • Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Dec 9, 2017
@codecov-io
Copy link

codecov-io commented Dec 9, 2017 •
edited
Loading

Codecov Report

Merging #945 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #945   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        32     32           
  Lines      3515   3515           
===================================
  Hits       3395   3395           
  Misses      120    120

@johlju
Changes to SqlServerDsc
3637dd3 
- Fix resources in alphabetical order in README.md (issue dsccommunity#908).
@johlju
Copy link
Member Author

johlju commented Dec 9, 2017

:LGTM:

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@johlju johlju merged commit 2610ba0 into dsccommunity:dev Dec 9, 2017
@vors vors removed the needs review The pull request needs a code review. label Dec 9, 2017
@johlju johlju deleted the fix-readme branch December 23, 2017 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SqlServerDsc: make the resources appear in alphabetical order in README.me
3 participants
@johlju @codecov-io @vors